Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QCC debug build flag #364

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

johnmcfarlane
Copy link
Contributor

Proposed changes

This change allows Boost to be built with q++ 7.1. Full details can be found in this boost issue. It essentially reimplements the patch provided by @Johnnyxy.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

As per the patch put forward in boostorg/build#453
@grafikrobot grafikrobot added bug Something isn't working in-progress Issues currently being looked at. labels Mar 8, 2024
@grafikrobot grafikrobot self-assigned this Mar 8, 2024
@grafikrobot grafikrobot merged commit 6df4b57 into bfgroup:main Mar 8, 2024
137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-progress Issues currently being looked at.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants